SuperTrend v2 by footon

58257 downloads / 8314 views / Created: 06.05.2016
 Average Rating: 0

Indicator Description

SuperTrend v2

Comments

I want to further customize for better result on in calculation segment that is based on volatility , period , ATR etc. to mathematical calculation with a some logic change.
Hi The indicator shows many errors while i add it in my MT5 i am a newbee please help
//============================================================== // Forex Strategy Builder // Copyright (c) Miroslav Popov. All rights reserved. //============================================================== // THIS CODE IS PROVIDED "AS IS" WITHOUT WARRANTY OF ANY KIND, // EITHER EXPRESSED OR IMPLIED, INCLUDING BUT NOT LIMITED TO // THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR // A PARTICULAR PURPOSE. //============================================================== using System; using System.Drawing; using ForexStrategyBuilder.Infrastructure.Entities; using ForexStrategyBuilder.Infrastructure.Enums; using ForexStrategyBuilder.Infrastructure.Interfaces; namespace ForexStrategyBuilder.Indicators.Store { public class SuperTrendv2 : Indicator { public SuperTrendv2() { IndicatorName = "SuperTrend v2"; PossibleSlots = SlotTypes.Open | SlotTypes.OpenFilter | SlotTypes.Close | SlotTypes.CloseFilter; IndicatorAuthor = "Footon"; IndicatorVersion = "2.0"; IndicatorDescription = "Footon's indi corner: custom indicators for FSB and FST."; } public override void Initialize(SlotTypes slotType) { SlotType = slotType; // The ComboBox parameters IndParam.ListParam[0].Caption = "Logic"; if (SlotType == SlotTypes.Open) IndParam.ListParam[0].ItemList = new string[] { "Enter the market at the Moving Average" }; else if (SlotType == SlotTypes.OpenFilter) IndParam.ListParam[0].ItemList = new string[] { "The Moving Average rises", "The Moving Average falls", "The bar opens above the Moving Average", "The bar opens below the Moving Average", "The bar opens above the Moving Average after opening below it", "The bar opens below the Moving Average after opening above it", "The position opens above the Moving Average", "The position opens below the Moving Average", }; else if (SlotType == SlotTypes.Close) IndParam.ListParam[0].ItemList = new string[] { "Exit the market at the Moving Average" }; else if (SlotType == SlotTypes.CloseFilter) IndParam.ListParam[0].ItemList = new string[] { "The Moving Average rises", "The Moving Average falls", "The bar closes below the Moving Average", "The bar closes above the Moving Average", }; else IndParam.ListParam[0].ItemList = new string[] { "Not Defined" }; IndParam.ListParam[0].Index = 0; IndParam.ListParam[0].Text = IndParam.ListParam[0].ItemList[IndParam.ListParam[0].Index]; IndParam.ListParam[0].Enabled = true; IndParam.ListParam[0].ToolTip = "Logic of application of the Moving Average."; // The NumericUpDown parameters IndParam.NumParam[0].Caption = "Period"; IndParam.NumParam[0].Value = 10; IndParam.NumParam[0].Min = 1; IndParam.NumParam[0].Max = 200; IndParam.NumParam[0].Enabled = true; IndParam.NumParam[0].ToolTip = "The ATR period."; IndParam.NumParam[1].Caption = "Multiplier"; IndParam.NumParam[1].Value = 3.0; IndParam.NumParam[1].Min = 1; IndParam.NumParam[1].Max = 200; IndParam.NumParam[1].Point = 1; IndParam.NumParam[1].Enabled = true; IndParam.NumParam[1].ToolTip = "Multiplier"; // The CheckBox parameters IndParam.CheckParam[0].Caption = "Use previous bar value"; IndParam.CheckParam[0].Enabled = true; IndParam.CheckParam[0].ToolTip = "Use the indicator value from the previous bar."; return; } public override void Calculate(IDataSet dataSet) { DataSet = dataSet; // Reading the parameters int iPeriod = (int)IndParam.NumParam[0].Value; double Multiplier = IndParam.NumParam[1].Value; int iPrvs = IndParam.CheckParam[0].Checked ? 1 : 0; // Calculation double[] adNonLagMA = new double[Bars]; double[] trend = new double[Bars]; double[] up = new double[Bars]; double[] dn = new double[Bars]; double[] medianPrice = new double[Bars]; double[] atr = new double[Bars]; // --------------------------------------------------------- var ATR = new AverageTrueRange(); ATR.Initialize(SlotType); ATR.IndParam.ListParam[1].Index = IndParam.ListParam[1].Index; ATR.IndParam.NumParam[0].Value = IndParam.NumParam[0].Value; ATR.IndParam.CheckParam[0].Checked = IndParam.CheckParam[0].Checked; ATR.Calculate(DataSet); atr = ATR.Component[0].Value; // ---------------------------------------------------------- int iFirstBar = iPeriod + iPrvs +1; int changeOfTrend = 0; int flag = 0; int flagh = 0; for (int iBar = 2; iBar < Bars; iBar++) { medianPrice[iBar] = (High[iBar]+Low[iBar])/2; up[iBar] = medianPrice[iBar] + (Multiplier*atr[iBar]); dn[iBar] = medianPrice[iBar] - (Multiplier*atr[iBar]); if (Close[iBar]>up[iBar-1]) { trend[iBar]=1; if (trend[iBar-1] == -1) changeOfTrend = 1; } else if (Close[iBar]0) { flag=1; } else { flag=0; } if (trend[iBar]>0 && trend[iBar-1]<0) { flagh=1; } else { flagh=0; } if (trend[iBar]>0 && dn[iBar]up[iBar-1]) up[iBar]=up[iBar-1]; //-- Draw the indicator if (trend[iBar]==1) { adNonLagMA[iBar]=dn[iBar]; } else if (trend[iBar]==-1) { adNonLagMA[iBar]=up[iBar]; } } //int iFirstBar = iPeriod + iShift + 1 + iPrvs; // Saving the components if (SlotType == SlotTypes.Open || SlotType == SlotTypes.Close) { Component = new IndicatorComp[2]; Component[1] = new IndicatorComp(); Component[1].Value = new double[Bars]; for (int iBar = iFirstBar; iBar < Bars; iBar++) { // Covers the cases when the price can pass through the MA without a signal double dValue = adNonLagMA[iBar - iPrvs]; // Current value double dValue1 = adNonLagMA[iBar - iPrvs - 1]; // Previous value double dTempVal = dValue; if ((dValue1 > High[iBar - 1] && dValue < Open[iBar]) || // The Open price jumps above the indicator (dValue1 < Low[iBar - 1] && dValue > Open[iBar]) || // The Open price jumps below the indicator (Close[iBar - 1] < dValue && dValue < Open[iBar]) || // The Open price is in a positive gap (Close[iBar - 1] > dValue && dValue > Open[iBar])) // The Open price is in a negative gap dTempVal = Open[iBar]; Component[1].Value[iBar] = dTempVal; // Entry or exit value } } else { Component = new IndicatorComp[3]; Component[1] = new IndicatorComp(); Component[1].ChartType = IndChartType.NoChart; Component[1].FirstBar = iFirstBar; Component[1].Value = new double[Bars]; Component[2] = new IndicatorComp(); Component[2].ChartType = IndChartType.NoChart; Component[2].FirstBar = iFirstBar; Component[2].Value = new double[Bars]; } Component[0] = new IndicatorComp(); Component[0].CompName = "MA Value"; Component[0].DataType = IndComponentType.IndicatorValue; Component[0].ChartType = IndChartType.Line; Component[0].ChartColor = Color.Red; Component[0].FirstBar = iFirstBar; Component[0].Value = adNonLagMA; if (SlotType == SlotTypes.Open) { Component[1].CompName = "Position opening price"; Component[1].DataType = IndComponentType.OpenPrice; } else if (SlotType == SlotTypes.OpenFilter) { Component[1].DataType = IndComponentType.AllowOpenLong; Component[1].CompName = "Is long entry allowed"; Component[2].DataType = IndComponentType.AllowOpenShort; Component[2].CompName = "Is short entry allowed"; } else if (SlotType == SlotTypes.Close) { Component[1].CompName = "Position closing price"; Component[1].DataType = IndComponentType.ClosePrice; } else if (SlotType == SlotTypes.CloseFilter) { Component[1].DataType = IndComponentType.ForceCloseLong; Component[1].CompName = "Close out long position"; Component[2].DataType = IndComponentType.ForceCloseShort; Component[2].CompName = "Close out short position"; } if (SlotType == SlotTypes.OpenFilter || SlotType == SlotTypes.CloseFilter) { switch (IndParam.ListParam[0].Text) { case "The Moving Average rises": IndicatorRisesLogic(iFirstBar, iPrvs, adNonLagMA, ref Component[1], ref Component[2]); break; case "The Moving Average falls": IndicatorFallsLogic(iFirstBar, iPrvs, adNonLagMA, ref Component[1], ref Component[2]); break; case "The bar opens above the Moving Average": BarOpensAboveIndicatorLogic(iFirstBar, iPrvs, adNonLagMA, ref Component[1], ref Component[2]); break; case "The bar opens below the Moving Average": BarOpensBelowIndicatorLogic(iFirstBar, iPrvs, adNonLagMA, ref Component[1], ref Component[2]); break; case "The bar opens above the Moving Average after opening below it": BarOpensAboveIndicatorAfterOpeningBelowLogic(iFirstBar, iPrvs, adNonLagMA, ref Component[1], ref Component[2]); break; case "The bar opens below the Moving Average after opening above it": BarOpensBelowIndicatorAfterOpeningAboveLogic(iFirstBar, iPrvs, adNonLagMA, ref Component[1], ref Component[2]); break; case "The position opens above the Moving Average": Component[0].PosPriceDependence = PositionPriceDependence.BuyHigherSellLower; Component[0].UsePreviousBar = iPrvs; Component[1].DataType = IndComponentType.Other; Component[1].ShowInDynInfo = false; Component[2].DataType = IndComponentType.Other; Component[2].ShowInDynInfo = false; break; case "The position opens below the Moving Average": Component[0].PosPriceDependence = PositionPriceDependence.BuyLowerSelHigher; Component[0].UsePreviousBar = iPrvs; Component[1].DataType = IndComponentType.Other; Component[1].ShowInDynInfo = false; Component[2].DataType = IndComponentType.Other; Component[2].ShowInDynInfo = false; break; case "The bar closes below the Moving Average": BarClosesBelowIndicatorLogic(iFirstBar, iPrvs, adNonLagMA, ref Component[1], ref Component[2]); break; case "The bar closes above the Moving Average": BarClosesAboveIndicatorLogic(iFirstBar, iPrvs, adNonLagMA, ref Component[1], ref Component[2]); break; default: break; } } return; } /// /// Sets the indicator logic description /// public override void SetDescription() { EntryPointLongDescription = "at the " + ToString(); EntryPointShortDescription = "at the " + ToString(); ExitPointLongDescription = "at the " + ToString(); ExitPointShortDescription = "at the " + ToString(); switch (IndParam.ListParam[0].Text) { case "The Moving Average rises": EntryFilterLongDescription = "the " + ToString() + " rises"; EntryFilterShortDescription = "the " + ToString() + " falls"; ExitFilterLongDescription = "the " + ToString() + " rises"; ExitFilterShortDescription = "the " + ToString() + " falls"; break; case "The Moving Average falls": EntryFilterLongDescription = "the " + ToString() + " falls"; EntryFilterShortDescription = "the " + ToString() + " rises"; ExitFilterLongDescription = "the " + ToString() + " falls"; ExitFilterShortDescription = "the " + ToString() + " rises"; break; case "The bar opens above the Moving Average": EntryFilterLongDescription = "the bar opens above the " + ToString(); EntryFilterShortDescription = "the bar opens below the " + ToString(); break; case "The bar opens below the Moving Average": EntryFilterLongDescription = "the bar opens below the " + ToString(); EntryFilterShortDescription = "the bar opens above the " + ToString(); break; case "The position opens above the Moving Average": EntryFilterLongDescription = "the position opening price is higher than the " + ToString(); EntryFilterShortDescription = "the position opening price is lower than the " + ToString(); break; case "The position opens below the Moving Average": EntryFilterLongDescription = "the position opening price is lower than the " + ToString(); EntryFilterShortDescription = "the position opening price is higher than the " + ToString(); break; case "The bar opens above the Moving Average after opening below it": EntryFilterLongDescription = "the bar opens above the " + ToString() + " after opening below it"; EntryFilterShortDescription = "the bar opens below the " + ToString() + " after opening above it"; break; case "The bar opens below the Moving Average after opening above it": EntryFilterLongDescription = "the bar opens below the " + ToString() + " after opening above it"; EntryFilterShortDescription = "the bar opens above the " + ToString() + " after opening below it"; break; case "The bar closes above the Moving Average": ExitFilterLongDescription = "the bar closes above the " + ToString(); ExitFilterShortDescription = "the bar closes below the " + ToString(); break; case "The bar closes below the Moving Average": ExitFilterLongDescription = "the bar closes below the " + ToString(); ExitFilterShortDescription = "the bar closes above the " + ToString(); break; default: break; } return; } /// /// Indicator to string /// public override string ToString() { string sString = IndicatorName + (IndParam.CheckParam[0].Checked ? "* (" : " (") + IndParam.ListParam[1].Text + ", " + // Method IndParam.ListParam[2].Text + ", " + // Price IndParam.NumParam[0].ValueToString + ", " + // MA period IndParam.NumParam[1].ValueToString + ")"; // MA shift return sString; } } }
//+--------------------------------------------------------------------+ //| Copyright: (C) 2014 Forex Software Ltd. | //| Website: http://forexsb.com/ | //| Support: http://forexsb.com/forum/ | //| License: Proprietary under the following circumstances: | //| | //| This code is a part of Forex Strategy Builder. It is free for | //| use as an integral part of Forex Strategy Builder. | //| One can modify it in order to improve the code or to fit it for | //| personal use. This code or any part of it cannot be used in | //| other applications without a permission. | //| The contact information cannot be changed. | //| | //| NO LIABILITY FOR CONSEQUENTIAL DAMAGES | //| | //| In no event shall the author be liable for any damages whatsoever | //| (including, without limitation, incidental, direct, indirect and | //| consequential damages, damages for loss of business profits, | //| business interruption, loss of business information, or other | //| pecuniary loss) arising out of the use or inability to use this | //| product, even if advised of the possibility of such damages. | //+--------------------------------------------------------------------+ #property copyright "Copyright (C) 2014 Forex Software Ltd." #property link "http://forexsb.com" #property version "2.00" #property strict #include <Forexsb.com/Indicator.mqh> #include <Forexsb.com/Enumerations.mqh> //+------------------------------------------------------------------+ //| | //+------------------------------------------------------------------+ class SuperTrendv2 : public Indicator { public: SuperTrendv2(SlotTypes slotType) { SlotType=slotType; IndicatorName="SuperTrend v2"; WarningMessage = ""; IsAllowLTF = true; ExecTime = ExecutionTime_DuringTheBar; IsSeparateChart = false; IsDiscreteValues = false; IsDefaultGroupAll = false; } virtual void Calculate(DataSet &dataSet); }; //+------------------------------------------------------------------+ //| | //+------------------------------------------------------------------+ void SuperTrendv2::Calculate(DataSet &dataSet) { Data=GetPointer(dataSet); // Reading the parameters int iPeriod = (int) NumParam[0].Value; double Multiplier = NumParam[1].Value; int previous=CheckParam[0].Checked ? 1 : 0; double adNonLagMA[]; ArrayResize(adNonLagMA,Data.Bars); ArrayInitialize(adNonLagMA,0); double trend[]; ArrayResize(trend,Data.Bars); ArrayInitialize(trend,0); double up[]; ArrayResize(up,Data.Bars); ArrayInitialize(up,0); double dn[]; ArrayResize(dn,Data.Bars); ArrayInitialize(dn,0); double medianPrice[]; ArrayResize(medianPrice,Data.Bars); ArrayInitialize(medianPrice,0); double atr1[]; ArrayResize(atr1,Data.Bars); ArrayInitialize(atr1,0); for(int bar=1; bar<Data.Bars; bar++) atr1[bar]=MathMax(Data.High[bar],Data.Close[bar-1])-MathMin(Data.Low[bar],Data.Close[bar-1]); double indicator1[]; MovingAverage(iPeriod,0,MAMethod_Simple,atr1,indicator1); // Calculation int firstBar=iPeriod+previous+1; int changeOfTrend = 0; int flag = 0; int flagh = 0; for (int iBar = 2; iBar < Data.Bars; iBar++) { medianPrice[iBar] = (Data.High[iBar]+Data.Low[iBar])/2; up[iBar] = medianPrice[iBar] + (Multiplier*indicator1[iBar]); dn[iBar] = medianPrice[iBar] - (Multiplier*indicator1[iBar]); if (Data.Close[iBar]>up[iBar-1]) { trend[iBar]=1; if (trend[iBar-1] == -1) changeOfTrend = 1; } else if (Data.Close[iBar]<dn[iBar-1]) { trend[iBar]=-1; if (trend[iBar-1] == 1) changeOfTrend = 1; } else if (trend[iBar-1]==1) { trend[iBar]=1; changeOfTrend = 0; } else if (trend[iBar-1]==-1) { trend[iBar]=-1; changeOfTrend = 0; } if (trend[iBar]<0 && trend[iBar-1]>0) { flag=1; } else { flag=0; } if (trend[iBar]>0 && trend[iBar-1]<0) { flagh=1; } else { flagh=0; } if (trend[iBar]>0 && dn[iBar]<dn[iBar-1]) dn[iBar]=dn[iBar-1]; if (trend[iBar]<0 && up[iBar]>up[iBar-1]) up[iBar]=up[iBar-1]; //-- Draw the indicator if (trend[iBar]==1) { adNonLagMA[iBar]=dn[iBar]; } else if (trend[iBar]==-1) { adNonLagMA[iBar]=up[iBar]; } } // Saving the components if(SlotType==SlotTypes_Open || SlotType==SlotTypes_Close) { ArrayResize(Component[1].Value, Data.Bars); ArrayInitialize(Component[1].Value,0); for(int bar=firstBar; bar<Data.Bars; bar++) { // Covers the cases when the price can pass through the MA without a signal double value = adNonLagMA[bar-previous]; // Current value double value1 = adNonLagMA[bar-previous-1]; // Previous value double tempVal = value; if((value1 > Data.High[bar - 1] && value < Data.Open[bar]) || // The Data.Open price jumps above the indicator (value1 < Data.Low[bar - 1] && value > Data.Open[bar]) || // The Data.Open price jumps below the indicator (Data.Close[bar-1]<value && value < Data.Open[bar]) || // The Data.Open price is in a positive gap (Data.Close[bar-1]>value && value > Data.Open[bar])) // The Data.Open price is in a negative gap tempVal=Data.Open[bar]; Component[1].Value[bar]=tempVal; // Entry or exit value } } else { ArrayResize(Component[1].Value, Data.Bars); ArrayResize(Component[2].Value, Data.Bars); } ArrayResize(Component[0].Value,Data.Bars); Component[0].CompName = "MA Value"; Component[0].DataType = IndComponentType_IndicatorValue; Component[0].FirstBar = firstBar; ArrayCopy(Component[0].Value,adNonLagMA); if(SlotType==SlotTypes_Open) { Component[1].CompName = "Position opening price"; Component[1].DataType = IndComponentType_OpenPrice; } if(SlotType==SlotTypes_OpenFilter) { Component[1].DataType = IndComponentType_AllowOpenLong; Component[1].CompName = "Is long entry allowed"; Component[2].DataType = IndComponentType_AllowOpenShort; Component[2].CompName = "Is short entry allowed"; } if(SlotType==SlotTypes_Close) { Component[1].CompName = "Position closing price"; Component[1].DataType = IndComponentType_ClosePrice; } if(SlotType==SlotTypes_CloseFilter) { Component[1].DataType = IndComponentType_ForceCloseLong; Component[1].CompName = "Close out long position"; Component[2].DataType = IndComponentType_ForceCloseShort; Component[2].CompName = "Close out short position"; } if(SlotType==SlotTypes_OpenFilter || SlotType==SlotTypes_CloseFilter) { if(ListParam[0].Text=="The Moving Average rises") IndicatorRisesLogic(firstBar,previous,adNonLagMA,Component[1],Component[2]); else if(ListParam[0].Text=="The Moving Average falls") IndicatorFallsLogic(firstBar,previous,adNonLagMA,Component[1],Component[2]); else if(ListParam[0].Text=="The bar opens above the Moving Average") BarOpensAboveIndicatorLogic(firstBar,previous,adNonLagMA,Component[1],Component[2]); else if(ListParam[0].Text=="The bar opens below the Moving Average") BarOpensBelowIndicatorLogic(firstBar,previous,adNonLagMA,Component[1],Component[2]); else if(ListParam[0].Text=="The bar opens above the Moving Average after opening below it") BarOpensAboveIndicatorAfterOpeningBelowLogic(firstBar,previous,adNonLagMA,Component[1],Component[2]); else if(ListParam[0].Text=="The bar opens below the Moving Average after opening above it") BarOpensBelowIndicatorAfterOpeningAboveLogic(firstBar,previous,adNonLagMA,Component[1],Component[2]); else if(ListParam[0].Text=="The position opens above the Moving Average") { Component[0].PosPriceDependence=PositionPriceDependence_BuyHigherSellLower; Component[1].DataType=IndComponentType_Other; Component[1].ShowInDynInfo=false; Component[2].DataType=IndComponentType_Other; Component[2].ShowInDynInfo=false; } else if(ListParam[0].Text=="The position opens below the Moving Average") { Component[0].PosPriceDependence=PositionPriceDependence_BuyLowerSellHigher; Component[1].DataType=IndComponentType_Other; Component[1].ShowInDynInfo=false; Component[2].DataType=IndComponentType_Other; Component[2].ShowInDynInfo=false; } else if(ListParam[0].Text=="The bar closes below the Moving Average") BarClosesBelowIndicatorLogic(firstBar,previous,adNonLagMA,Component[1],Component[2]); else if(ListParam[0].Text=="The bar closes above the Moving Average") BarClosesAboveIndicatorLogic(firstBar,previous,adNonLagMA,Component[1],Component[2]); } } //+------------------------------------------------------------------+
Risk warning: Forex, spread bets and CFD are leveraged products. They may not be suitable for you as they carry a high degree of risk to your capital and you can lose more than your initial investment. You should ensure you understand all of the risks.
Copyright © 2006 - 2024, Forex Software Ltd.;