To learn the code, for my first task, I've added a feature requested by a user to exit after a set number of bars. It's very exciting, it's a CloseFilter so it should be good for:
- use alone -- exit at close of N bars from opening of position
- use with another indicator -- exit at N bars, or other indicator signal, whichever is first
- logical A with other indicator logical B -- exit at N bars, or other indicator signal, whichever is first
- logical A with other indicator logical A -- exit at N bars (or higher) and other indicator signal
I am still testing smoke levels. I am almost done, maybe by this weekend. How to I submit the change for review? I'd be happy to discuss how I've implemented it too before submitting, be sure I understand FSB correctly and have not missed something important.
Is it too early to add a feature, would it be better to stick to the ToDo list for now? I haven't seen an update on the wiki, so I don't know what ToDo tasks are still to do.