Forex Software — (Bug?) Slightly Different GetTrailingStopPrice() code between MT4/5

Re: (Bug?) Slightly Different GetTrailingStopPrice() code between MT4/5

null@example.com (geektrader) — Tue, 22 Mar 2022 23:03:30 +0000

Thank you for fixing it.

Re: (Bug?) Slightly Different GetTrailingStopPrice() code between MT4/5

null@example.com (Popov) — Mon, 21 Mar 2022 10:39:38 +0000

The Experts code is updated.

Thank you again for the report!

Re: (Bug?) Slightly Different GetTrailingStopPrice() code between MT4/5

null@example.com (geektrader) — Thu, 10 Mar 2022 06:26:27 +0000

I see, smart idea. Then I will remove it. Many thanks.

Re: (Bug?) Slightly Different GetTrailingStopPrice() code between MT4/5

null@example.com (Popov) — Wed, 09 Mar 2022 11:06:11 +0000

Hello GeekTrader,

Thank you for the report.
Actually the "&& stopLossPrice < bid" should be removed from MT4 code.

We do the check inside the if.
If "stopLossPrice < bid" then we set SL. The SL is set to "bid" otherwise.
It works in the case of a big gap where the "bid" jumps over SL.

(Bug?) Slightly Different GetTrailingStopPrice() code between MT4/5

null@example.com (geektrader) — Wed, 09 Mar 2022 00:37:37 +0000

Hi Mr. Popov,

I´ve noticed that the GetTrailingStopPrice() function between MT4/5 is almost 100% identical, just one line (an extra check) is different. Shouldn´t this extra line from the MT4 function be added to the MT5 function as well?

MT4 function:

double GetTrailingStopPrice()
  {
   double bid = Bid();
   double ask = Ask();
   double stopLevelPoints = _Point * stopLevel;
   double stopLossPoints  = pip * Stop_Loss;

   if (posType == OP_BUY)
     {
      double stopLossPrice = High[1] - stopLossPoints;
      if (posStopLoss < stopLossPrice - pip && stopLossPrice < bid)
         return stopLossPrice < bid
                 ? stopLossPrice >= bid - stopLevelPoints
                    ? bid - stopLevelPoints
                    : stopLossPrice
                 : bid;
     }

   if (posType == OP_SELL)
     {
      double stopLossPrice = Low[1] + stopLossPoints;
      if (posStopLoss > stopLossPrice + pip)
         return stopLossPrice > ask
                 ? stopLossPrice <= ask + stopLevelPoints
                    ? ask + stopLevelPoints
                    : stopLossPrice
                 : ask;
     }

   return posStopLoss;
  }

MT5 function:

double GetTrailingStopPrice()
  {
   double bid = Bid();
   double ask = Ask();
   double stopLevelPoints = _Point * stopLevel;
   double stopLossPoints  = pip * Stop_Loss;

   if (posType == OP_BUY)
     {
      double stopLossPrice = High(1) - stopLossPoints;
      if (posStopLoss < stopLossPrice - pip)
         return stopLossPrice < bid
                  ? stopLossPrice >= bid - stopLevelPoints
                     ? bid - stopLevelPoints
                     : stopLossPrice
                  : bid;
     }

   if (posType == OP_SELL)
     {
      double stopLossPrice = Low(1) + stopLossPoints;
      if (posStopLoss > stopLossPrice + pip)
         return stopLossPrice > ask
                  ? stopLossPrice <= ask + stopLevelPoints
                     ? ask + stopLevelPoints
                     : stopLossPrice
                  : ask;
     }

   return posStopLoss;
  }

The difference is in this line (MT4) which is missing in MT5:

      if (posStopLoss < stopLossPrice - pip && stopLossPrice < bid)

I think that extra check "&& stopLossPrice < bid" should be added to the MT5 function as well?

Thank you :-)