<![CDATA[Forex Software — Risk Percent]]> https://forexsb.com/forum/topic/8020/risk-percent/ Sun, 25 Apr 2021 06:46:53 +0000 PunBB <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/64825/#p64825 Mr. Popov I was thinking to add 5 experts with 1%-2% but anyway, it is ok also to have a code similar to the post from Roughey. Unfortunately, I inserted several times in the last year and it is not working for me. And I have no idea about programming...

Please, if is not such a big work for you, just give us a general code (which works) to be inserted manually..

thanks
Sebastian

]]> Sun, 25 Apr 2021 06:46:53 +0000 https://forexsb.com/forum/post/64825/#p64825 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/64824/#p64824 What will happen if you enter 50% and run 3 experts?

]]> Sun, 25 Apr 2021 06:03:28 +0000 https://forexsb.com/forum/post/64824/#p64824 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/64823/#p64823 is it not possible to add the percentage risk as a trade option into the expert advisor?

]]> Sun, 25 Apr 2021 05:59:54 +0000 https://forexsb.com/forum/post/64823/#p64823 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57687/#p57687 Hello Roughey,

So i have been trying out the code for one week now, and it works, but there is still something missing.

When i put 10 in the Entry Percent input, the EA dont risk 10% of the account balance/equity but risk only 2-3%.


Why and do i miss something?


Thanks and happy weekend guys!

]]> Fri, 25 Oct 2019 16:00:41 +0000 https://forexsb.com/forum/post/57687/#p57687 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57605/#p57605 One more thing, if it's not to much to ask.

Is it possible to make the EA only have 1 trade open at once?

So if there is an open position no new trade will be executed before the old position is closed

Thanks.

]]> Fri, 18 Oct 2019 18:51:48 +0000 https://forexsb.com/forum/post/57605/#p57605 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57604/#p57604 Roughey! It finally works!

Did several tests, and it seems like it works perfectly. Will be putting out some EA's next week and see how it goes.

Thank you again for helping me out, really appreciate it Roughey.

]]> Fri, 18 Oct 2019 15:34:18 +0000 https://forexsb.com/forum/post/57604/#p57604 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57589/#p57589 you are using Entry_Amount 2 times.. one time for your calculation and one time here

void OpenPosition(Signal &signal)
  {
   for(int attempt=0; attempt<TRADE_RETRY_COUNT; attempt++)
     {
      int    ticket     = 0;
      int    lastError  = 0;
      bool   modified   = false;
      int    command    = OrderDirectionToCommand(signal.Direction);
      double amount     = Entry_Amount;

So he is taking the 0,01 lots.


So you make it like this

#define OP_FLAT           -1

// Session time is set in seconds from 00:00
const int sessionSundayOpen           = 0;     // 00:00
const int sessionSundayClose          = 86400; // 24:00
const int sessionMondayThursdayOpen   = 36000; // 10:00
const int sessionMondayThursdayClose  = 61200; // 17:00
const int sessionFridayOpen           = 36000; // 10:00
const int sessionFridayClose          = 61200; // 17:00
const bool sessionIgnoreSunday        = true;
const bool sessionCloseAtSessionClose = false;
const bool sessionCloseAtFridayClose  = false;


input bool useFixLot = false; //Use Fix Lot
input double FixLot = 0.01; // Fix Lotsize
input bool                usePercent                        = true;                // Use Risk Percent base on AccountBalance
input double             Entry_Percent              = 2.00;                 // ENTRY PERCENT



const int    strategiesCount = 10;
const double sigma           = 0.000001;

datetime barTime;
int      digits;
double   stopLevel;
double   pip;
bool     setProtectionSeparately = false;
double Entry_Amount;

//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+

AND IN ONTICK ADD THIS

if(usePercent==true)
      {
      int margin=(int) MarketInfo(_Symbol,MODE_MARGINREQUIRED);
         Entry_Amount =(Entry_Percent/100)*AccountEquity()/margin;
         Entry_Amount = NormalizeEntrySize(Entry_Amount);
Comment("Next Lotsize: "+DoubleToString(Entry_Amount));    <---Optional
      }
if(useFixLot == true)
{
Entry_Amount = FixLot;
}

This must working!!!

]]> Thu, 17 Oct 2019 20:14:26 +0000 https://forexsb.com/forum/post/57589/#p57589 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57588/#p57588 Here is a picture of the whole EA

https://imgur.com/a/zoNr4kh

]]> Thu, 17 Oct 2019 17:46:10 +0000 https://forexsb.com/forum/post/57588/#p57588 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57584/#p57584 Error: 'Entry_Amount' - constant cannot be modified

Picture of error:
https://imgur.com/a/7Kcipnt

]]> Thu, 17 Oct 2019 15:48:36 +0000 https://forexsb.com/forum/post/57584/#p57584 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57583/#p57583 send error code.

]]> Thu, 17 Oct 2019 15:39:37 +0000 https://forexsb.com/forum/post/57583/#p57583 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57569/#p57569 So i did the change, but it seems like the Entry_Amount error is still the problem.

So i removed the static from the Entry_Amount

//
// EA Studio Portfolio Expert Advisor
//
// Created with: Expert Advisor Studio
// Website: https://eaforexacademy.com/expert-advisor-studio/
//
// Copyright 2019, Forex Software Ltd.
//
// This Portfolio Expert works in MetaTrader 4.
// It opens separate positions for each strategy.
// Every position has an unique magic number,
// which corresponds to the index of the strategy.
//

#property copyright "Forex Software Ltd."
#property version   "2.4"
#property strict

input double Entry_Amount      = 0.01; // Entry lots <<<<<<<<<<<<<<Removed static
static input int    Base_Magic_Number = 100;  // Base Magic Number

#define TRADE_RETRY_COUNT 4
#define TRADE_RETRY_WAIT  100
#define OP_FLAT           -1

// Session time is set in seconds from 00:00
const int sessionSundayOpen           = 0;     // 00:00
const int sessionSundayClose          = 86400; // 24:00
const int sessionMondayThursdayOpen   = 36000; // 10:00
const int sessionMondayThursdayClose  = 61200; // 17:00
const int sessionFridayOpen           = 36000; // 10:00
const int sessionFridayClose          = 61200; // 17:00
const bool sessionIgnoreSunday        = true;
const bool sessionCloseAtSessionClose = false;
const bool sessionCloseAtFridayClose  = false;

input bool                usePercent                        = true;                // Use Risk Percent base on AccountBalance
input double               Entry_Percent              = 2.00;                 // ENTRY PERCENT



const int    strategiesCount = 10;
const double sigma           = 0.000001;

datetime barTime;
int      digits;
double   stopLevel;
double   pip;
bool     setProtectionSeparately = false;

//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+


Added the normalize in, and the last part outside ontick



//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void OnTick()

  {
   if(IsForceSessionClose())
     {
      CloseAllPositions();
      return;
     }

   if(Time[0]>barTime)
     {
      barTime=Time[0];
      OnBar();
     }
     
   if(usePercent==true)
      {
      int margin=(int) MarketInfo(_Symbol,MODE_MARGINREQUIRED);
         Entry_Amount =(Entry_Percent/100)*AccountEquity()/margin;
         Entry_Amount = NormalizeEntrySize(Entry_Amount);
      }
    
  }
  
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
  
  
 double NormalizeEntrySize(double size) {
   double minlot  = MarketInfo(_Symbol, MODE_MINLOT);
   double maxlot  = MarketInfo(_Symbol, MODE_MAXLOT);
   double lotstep = MarketInfo(_Symbol, MODE_LOTSTEP);

   if (size <= minlot)
       return (minlot);

   int steps = (int) MathRound((size - minlot) / lotstep);
   size = minlot + steps * lotstep;

   if (size >= maxlot)
       size = maxlot;
       
   size = NormalizeDouble(size, digits);   

   return (size);
}    
  
  
  
  
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+

Have i forgot something?

Thanks guys smile

]]> Thu, 17 Oct 2019 04:17:09 +0000 https://forexsb.com/forum/post/57569/#p57569 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57566/#p57566 yes delete the static and than it must work..also you have to check if entry amount is possible to your broker..so you have to normalize it.

      int margin=(int) MarketInfo(_Symbol,MODE_MARGINREQUIRED);
         Entry_Amount=(Entry_Percent/100)*AccountEquity()/margin;}
ADD THIS--->        Entry_Amount = NormalizeEntrySize(Entry_Amount);

add this


and add this outside ontick

double NormalizeEntrySize(double size) {
   double minlot  = MarketInfo(_Symbol, MODE_MINLOT);
   double maxlot  = MarketInfo(_Symbol, MODE_MAXLOT);
   double lotstep = MarketInfo(_Symbol, MODE_LOTSTEP);

   if (size <= minlot)
       return (minlot);

   int steps = (int) MathRound((size - minlot) / lotstep);
   size = minlot + steps * lotstep;

   if (size >= maxlot)
       size = maxlot;
       
   size = NormalizeDouble(size, digits);   

   return (size);
}
]]> Wed, 16 Oct 2019 20:59:25 +0000 https://forexsb.com/forum/post/57566/#p57566 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57565/#p57565 Riuzk wrote:

Thank you Roughey, appreciate your effort helping out members smile

But it seems like i have some issue inserting it to my EA

This i what i did:

I inserted these two lines, almost at the begining

input bool                usePercent          = true;     // Use Risk Percent base on AccountBalance
input double               Entry_Percent        = 2.00;                 // ENTRY PERCENT



//
// EA Studio Portfolio Expert Advisor
//
// Created with: Expert Advisor Studio
// Website: https://eaforexacademy.com/expert-advisor-studio/
//
// Copyright 2019, Forex Software Ltd.
//
// This Portfolio Expert works in MetaTrader 4.
// It opens separate positions for each strategy.
// Every position has an unique magic number,
// which corresponds to the index of the strategy.
//

#property copyright "Forex Software Ltd."
#property version   "2.4"
#property strict

static input double Entry_Amount      = 0.01; // Entry lots
static input int    Base_Magic_Number = 100;  // Base Magic Number

#define TRADE_RETRY_COUNT 4
#define TRADE_RETRY_WAIT  100
#define OP_FLAT           -1

// Session time is set in seconds from 00:00
const int sessionSundayOpen           = 0;     // 00:00
const int sessionSundayClose          = 86400; // 24:00
const int sessionMondayThursdayOpen   = 36000; // 10:00
const int sessionMondayThursdayClose  = 61200; // 17:00
const int sessionFridayOpen           = 36000; // 10:00
const int sessionFridayClose          = 61200; // 17:00
const bool sessionIgnoreSunday        = true;
const bool sessionCloseAtSessionClose = false;
const bool sessionCloseAtFridayClose  = false;

input bool                usePercent                        = true;                // Use Risk Percent base on AccountBalance
input double               Entry_Percent              = 2.00;                 // ENTRY PERCENT


const int    strategiesCount = 10;
const double sigma           = 0.000001;

datetime barTime;
int      digits;
double   stopLevel;
double   pip;
bool     setProtectionSeparately = false;

//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+

And the other part here

//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void OnTick()

  {
   if(IsForceSessionClose())
     {
      CloseAllPositions();
      return;
     }

   if(Time[0]>barTime)
     {
      barTime=Time[0];
      OnBar();
     }
     
   if(usePercent==true)
      {
      int margin=(int) MarketInfo(_Symbol,MODE_MARGINREQUIRED);
         Entry_Amount =(Entry_Percent/100)*AccountEquity()/margin;
      }
    
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+

I got 1 error when im trying to compile it:
'Entry_Amount' - constant cannot be modified

Could you help me out on what i did wrong here or maybe send an EA with the code inserted aldready.

Thanks smile

I may be wrong but I believe it is because you have Entry amount as a Static Input. Trying removing the word static and compile

]]> Wed, 16 Oct 2019 20:37:28 +0000 https://forexsb.com/forum/post/57565/#p57565 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57564/#p57564 Thank you Roughey, appreciate your effort helping out members smile

But it seems like i have some issue inserting it to my EA

This i what i did:

I inserted these two lines, almost at the begining

input bool                usePercent          = true;     // Use Risk Percent base on AccountBalance
input double               Entry_Percent        = 2.00;                 // ENTRY PERCENT



//
// EA Studio Portfolio Expert Advisor
//
// Created with: Expert Advisor Studio
// Website: https://eaforexacademy.com/expert-advisor-studio/
//
// Copyright 2019, Forex Software Ltd.
//
// This Portfolio Expert works in MetaTrader 4.
// It opens separate positions for each strategy.
// Every position has an unique magic number,
// which corresponds to the index of the strategy.
//

#property copyright "Forex Software Ltd."
#property version   "2.4"
#property strict

static input double Entry_Amount      = 0.01; // Entry lots
static input int    Base_Magic_Number = 100;  // Base Magic Number

#define TRADE_RETRY_COUNT 4
#define TRADE_RETRY_WAIT  100
#define OP_FLAT           -1

// Session time is set in seconds from 00:00
const int sessionSundayOpen           = 0;     // 00:00
const int sessionSundayClose          = 86400; // 24:00
const int sessionMondayThursdayOpen   = 36000; // 10:00
const int sessionMondayThursdayClose  = 61200; // 17:00
const int sessionFridayOpen           = 36000; // 10:00
const int sessionFridayClose          = 61200; // 17:00
const bool sessionIgnoreSunday        = true;
const bool sessionCloseAtSessionClose = false;
const bool sessionCloseAtFridayClose  = false;

input bool                usePercent                        = true;                // Use Risk Percent base on AccountBalance
input double               Entry_Percent              = 2.00;                 // ENTRY PERCENT


const int    strategiesCount = 10;
const double sigma           = 0.000001;

datetime barTime;
int      digits;
double   stopLevel;
double   pip;
bool     setProtectionSeparately = false;

//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+

And the other part here

//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void OnTick()

  {
   if(IsForceSessionClose())
     {
      CloseAllPositions();
      return;
     }

   if(Time[0]>barTime)
     {
      barTime=Time[0];
      OnBar();
     }
     
   if(usePercent==true)
      {
      int margin=(int) MarketInfo(_Symbol,MODE_MARGINREQUIRED);
         Entry_Amount =(Entry_Percent/100)*AccountEquity()/margin;
      }
    
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+

I got 1 error when im trying to compile it:
'Entry_Amount' - constant cannot be modified

Could you help me out on what i did wrong here or maybe send an EA with the code inserted aldready.

Thanks smile

]]> Wed, 16 Oct 2019 19:07:29 +0000 https://forexsb.com/forum/post/57564/#p57564 <![CDATA[Re: Risk Percent]]> https://forexsb.com/forum/post/57561/#p57561 
input bool                usePercent                        = true;                // Use Risk Percent base on AccountBalance
input double               Entry_Percent              = 2.00;                 // ENTRY PERCENT
Put in OnTick this:
if(usePercent==true)
      int margin=(int) MarketInfo(_Symbol,MODE_MARGINREQUIRED);
         Entry_Amount=(Entry_Percent/100)*AccountEquity()/margin;}
]]> Wed, 16 Oct 2019 16:08:16 +0000 https://forexsb.com/forum/post/57561/#p57561