- renamed as Trade Distribution Chart
- buttons on small background under title bar
- with tooltips

Not yet with StatsBuffer.

Should it be used in Small Histogram chart?

I made Small Balance Chart taking data from StatsBuffer, but there was a side effect. It worked perfectly on the main screen. But this chart is also included in the Generator, Optimizer ... What happened is that the chart in the Generator was always showing the balance of the strategy on the main screen
I have to rethink the solution. StatsBuffer has to be used only from panels on the main screen because it contains data only for the strategy shown on the main screen. Other panels on Generator or Optimizer has to use local copy of the raw data or to update from Backtester class.

Small Balance Chart and probably Histogram Chart has to use local copy of the raw data. This is because these charts can be shown on main screen and also in some tools like Generator.

Or maybe the charts has to use StatsBuffer when they are shown on main screen and Backtester, when they are shown in a dynamic tool. I'll make some tests with this logic and will update the codes.

thanks

The chart was updated in order to shows also the reversals and reducing trades.

for (int bar = 0; bar < Data.Bars; bar++)
{
    for (int pos = 0; pos < Backtester.Positions(bar); pos++)
    {
        Transaction transaction = Backtester.PosTransaction(bar, pos);
        if (transaction == Transaction.Close  ||
            transaction == Transaction.Reduce ||
            transaction == Transaction.Reverse)
        {
            results[ctr] = (int)Backtester.PosProfitLoss(bar, pos);
            ctr++;
        }
    }
}

On my local copy, I've added for Transaction.Close || Reduce || Reverse.
Small Histogram Chart:
- changed title bar name to "Trade Distribution Chart"
- added bar under title bar for buttons (Toggle, Clipboard and Export)

TBD -- use StatsBuffer instead of Backtest class directly

After I get StatBuffer in there, I will upload to my github repository.

/// <summary>
/// Arrange the controls after resizing
/// </summary>
void pnlMarket_Resize(object sender, EventArgs e)
{
    smallIndicatorChart.Height = 2 * pnlMarket.ClientSize.Height / (Configs.ShowJournal ? 3 : 4);
    smallHistogramChart.Height = 2 * pnlMarket.ClientSize.Height / (Configs.ShowJournal ? 3 : 4);
}

versus

/// <summary>
/// Arrange the controls after resizing
/// </summary>
void pnlMarket_Resize(object sender, EventArgs e)
{
    smallIndicatorChart.Height = 2 * pnlMarket.ClientSize.Height / (Configs.ShowJournal ? 3 : 4);
    smallIndicatorChart.Height = 2 * pnlMarket.ClientSize.Height / (Configs.ShowJournal ? 3 : 4);
}

Yes, if possible -- I couldn't get the initialization and event handlers to work out right, I couldn't figure it out.

I think it is what happens -- it considers a trade complete by searching for Transaction.Close, and the counts are based on transactions that are Transaction.Close. So, does it need to include Transaction.Reverse?
I'm not sure how to handle Transaction.Reduce, is the close lot considered a trade, or when all open lots are finally closed? I would prefer when all open lots are closed and there are no more open lots, it would make it easier to get the result (from Position.ProfitLoss).

I agree, I will have to change it to use the StatsBuffer class.

The Histogram Chart shows only loosing trades for the included in the distribution Demo MACD Reversal strategy.

Another issue is that the histogram chart doesn't take the same size as the indicator chart. (Do you need help with this?)

Also the chart takes raw values from the Backtester class. This can lead to an issue when the chart is forced to recalculate during the work of Generator or Optimizer. Th problem comes from the fact that Generator uses the Backtester class for its calculations and puts temporary values there. If happens that the user interface charts or journals need recalculation at that time, they will receive the temp values from the Generator instead of the already fixed strategy on the main screen. That's why I started developing this StatsBuffer. My idea is the main screen panels to use data only from it. I'll expand the buffer with the necessary data for the Histogram Chart and we can redirect the sources to the buffer.

Here is a screenshot, I was able to add to the left to toggle between the Indicator chart:

- ToolStrip to hold buttons for toggling between Indicator and Histogram
- Splitter under ToolStrip to resize charts
- 3 buttons on Histogram chart for
  * toggle between Count and Cumulative views
  * copy histogram data to Clipboard
  * Export histogram data to CSV file

This addition is minimally invasive, adding only Small Histogram Chart.cs. Modified files:
- Controls Market.cs
- Actions.cs
- Exporter.cs

To get the histogram data from somewhere else in the code, the calculating method is static and publicly available as:

Small_Histogram_Chart.GetHistogramDataInts(out int[] results, out int[] indexes, out int[] counts, out int[] cumulatives)

I think this will work, I didn't test it, let me know if it doesn't work, it will be easy to remove it.

These details, I wasn't able to do them:
- putting Toggle/Clipbard/Export buttons on the right
- generating the language files (but all strings are in Language.T('myString') form)
- making the Indicator and Histogram charts the same size all the time so when toggling between them the chart space does not jump around

I've also had a few Visual Studio crashes in debugging when using the Clipboard feature. I haven't seen it with the exe, so hopefully it's just something about Vis Stud.

Let me if any comments or questions, then if it's passes review, I'll send on the push request in github.

how to make a public callable function for the class's private function with out parameters:

private void getHistogramDataInts (out int[] results, out int[] indexes, out int[] counts, out int[] cumulatives)

I've tried:

public void GetHistogramDataInts { get { getHistogramDataInts( ); } }
public void GetHistogramDataInts { get { getHistogramDataInts(out int[] results, out int[] indexes, out int[] counts, out int[] cumulatives ); } }
public int[][][][] GetHistogramDataInts { get { getHistogramDataInts(out int[] results, out int[] indexes, out int[] counts, out int[] cumulatives ); } }
public void GetHistogramDataInts { get { getHistogramDataInts(new int[], new int[], new int[], new int[] ); } }

and several other combinations like that, but I've had no luck finding one that works ...

Hello Krog,
You have to make both charts with equal size and location and to toggle their visibility. See how it's done in the generator's chart.
You also have to use Language.T("MyString") in orther to make the text translatable. After that you have to add the new strings in the Bulgarian.xml file in the Resources folder of the project. Just put both strings in english. Latter, when you start the program FSB will tell you that the new string is not in the language file. This is because FSB compares the integrated Bulgarian.xml with every language file at loading. You don't need to add the new phrases  manually in all the lang files. Just use genlangfiles and repairlang commands from the console. FSB will inject the new phrases in the lang files. After that the phrases can be translated by using the Edit Translation tool.

Ok, I'll try to do that before submitting to github.